changeset 638:74237f60f8a9

0.6dev: Improving builds overview page layout, take 2. Re-closing #430.
author osimons
date Tue, 18 Aug 2009 20:01:16 +0000
parents 988f2b3e585c
children 5e78705333c3
files bitten/htdocs/bitten.css bitten/templates/bitten_config.html bitten/web_ui.py
diffstat 3 files changed, 9 insertions(+), 13 deletions(-) [+]
line wrap: on
line diff
--- a/bitten/htdocs/bitten.css
+++ b/bitten/htdocs/bitten.css
@@ -57,16 +57,15 @@
 
 #content.build p.path { color: #999; font-size: smaller; margin-top: 0; }
 
-#content.build #charts { clear: right; float: right; width: 25%; }
+#content.build #charts { clear: right; float: right; margin-left: 0.5em; }
 
 #content.build #builds { clear: none; margin-top: 2em; table-layout: fixed;
-  width: 73%;
+  width: auto;
 }
 #content.build #builds tbody th, #content.build #builds tbody td {
-  background: #fff;
+  background: #fff; width: 40em;
 }
-#content.build #builds th.longrevchgset { width: 30%; }
-#content.build #builds th.shortrevchgset { width: 6em; }
+#content.build #builds th.chgset { width: 5em; }
 #content.build #builds td :link, #content.build #builds td :visited {
   font-weight: bold;
 }
--- a/bitten/templates/bitten_config.html
+++ b/bitten/templates/bitten_config.html
@@ -156,13 +156,13 @@
       <table py:if="config.platforms and config.builds"
              class="listing" id="builds">
         <thead><tr>
-          <th class="${config.revsize}"><abbr title="Changeset">Chgset</abbr></th>
+          <th class="chgset"><abbr title="Changeset">Chgset</abbr></th>
           <th py:for="platform in config.platforms">$platform.name</th>
         </tr></thead>
         <tbody py:if="config.builds">
           <tr py:for="rev_num in sorted(config.builds, reverse=True)"
               py:with="rev = config.builds[rev_num]">
-            <th class="${config.revsize}" scope="row">
+            <th class="chgset" scope="row">
               <a href="$rev.href" title="View Changeset">[$rev_num]</a>
             </th><py:for each="platform in config.platforms"><py:choose>
             <td py:when="platform.id in rev" py:with="build = rev[platform.id]"
@@ -189,10 +189,10 @@
       </h2>
       <table class="listing" id="builds">
         <thead><tr>
-          <th class="${config.revsize}" abbrev="Changeset">Chgset</th><th>Build</th>
+          <th class="chgset" abbrev="Changeset">Chgset</th><th>Build</th>
         </tr></thead><tbody>
         <tr py:for="build in config.builds">
-          <th class="${config.revsize}" scope="row">
+          <th class="chgset" scope="row">
             <a href="$build.rev_href" title="View Changeset">[$build.rev]</a>
           </th>
           <td class="$build.cls">
--- a/bitten/web_ui.py
+++ b/bitten/web_ui.py
@@ -368,8 +368,7 @@
             'active': config.active, 'description': description,
             'browser_href': req.href.browser(config.path),
             'builds_pending' : len(pending_builds),
-            'builds_inprogress' : len(inprogress_builds),
-            'revsize' : None,
+            'builds_inprogress' : len(inprogress_builds)
         }
 
         context = Context.from_request(req, config.resource)
@@ -428,8 +427,6 @@
             elif idx >= (page - 1) * builds_per_page:
                 builds.setdefault(rev, {})
                 builds[rev].setdefault('href', req.href.changeset(rev))
-                data['config']['revsize'] = len(str(rev)) > 10 \
-                                    and 'longrevchgset' or 'shortrevchgset'
                 if build and build.status != Build.PENDING:
                     build_data = _get_build_data(self.env, req, build)
                     build_data['steps'] = []
Copyright (C) 2012-2017 Edgewall Software