Mercurial > babel > mirror
annotate babel/messages/checkers.py @ 416:3e2c8b5573a1 trunk
Removed `ValueError` raising for string formatting message checkers if the string does not contain any string formattings. The new behavior is undefined. This fixes at least one of the problems of the #150 ticket.
author | aronacher |
---|---|
date | Fri, 31 Oct 2008 16:13:59 +0000 |
parents | 05487ae7696e |
children | ac8961d40e61 2baa2cedd6f9 |
rev | line source |
---|---|
220
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
1 # -*- coding: utf-8 -*- |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
2 # |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
3 # Copyright (C) 2007 Edgewall Software |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
4 # All rights reserved. |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
5 # |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
6 # This software is licensed as described in the file COPYING, which |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
7 # you should have received as part of this distribution. The terms |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
8 # are also available at http://babel.edgewall.org/wiki/License. |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
9 # |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
10 # This software consists of voluntary contributions made by many |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
11 # individuals. For the exact contribution history, see the revision |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
12 # history and logs, available at http://babel.edgewall.org/log/. |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
13 |
234 | 14 """Various routines that help with validation of translations. |
15 | |
16 :since: version 0.9 | |
17 """ | |
220
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
18 |
352
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
19 from itertools import izip |
220
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
20 from babel.messages.catalog import TranslationError, PYTHON_FORMAT |
414
05487ae7696e
fix Python 2.3 compat: rearrange set/itemgetter/rsplit/sorted/unicode.decode
pjenvey
parents:
364
diff
changeset
|
21 from babel.util import set |
220
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
22 |
352
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
23 #: list of format chars that are compatible to each other |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
24 _string_format_compatibilities = [ |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
25 set(['i', 'd', 'u']), |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
26 set(['x', 'X']), |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
27 set(['f', 'F', 'g', 'G']) |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
28 ] |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
29 |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
30 |
220
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
31 def num_plurals(catalog, message): |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
32 """Verify the number of plurals in the translation.""" |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
33 if not message.pluralizable: |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
34 if not isinstance(message.string, basestring): |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
35 raise TranslationError("Found plural forms for non-pluralizable " |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
36 "message") |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
37 return |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
38 |
355
9a2618ab9bbc
Refactored the checker system. It's now possible to partially validate translations on a per-message level.
aronacher
parents:
353
diff
changeset
|
39 # skip further tests if no catalog is provided. |
9a2618ab9bbc
Refactored the checker system. It's now possible to partially validate translations on a per-message level.
aronacher
parents:
353
diff
changeset
|
40 elif catalog is None: |
9a2618ab9bbc
Refactored the checker system. It's now possible to partially validate translations on a per-message level.
aronacher
parents:
353
diff
changeset
|
41 return |
9a2618ab9bbc
Refactored the checker system. It's now possible to partially validate translations on a per-message level.
aronacher
parents:
353
diff
changeset
|
42 |
220
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
43 msgstrs = message.string |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
44 if not isinstance(msgstrs, (list, tuple)): |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
45 msgstrs = (msgstrs,) |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
46 if len(msgstrs) != catalog.num_plurals: |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
47 raise TranslationError("Wrong number of plural forms (expected %d)" % |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
48 catalog.num_plurals) |
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
49 |
352
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
50 |
220
97b4b289e792
Added infrastructure for adding catalog checkers, and implement a checker that validations Python format parameters in translations, closing #19.
cmlenz
parents:
diff
changeset
|
51 def python_format(catalog, message): |
353
0791b3bf42cc
Fixed a small bug in the python format string checker that caused the wrong exception to be thrown.
aronacher
parents:
352
diff
changeset
|
52 """Verify the format string placeholders in the translation.""" |
352
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
53 if 'python-format' not in message.flags: |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
54 return |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
55 msgids = message.id |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
56 if not isinstance(msgids, (list, tuple)): |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
57 msgids = (msgids,) |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
58 msgstrs = message.string |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
59 if not isinstance(msgstrs, (list, tuple)): |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
60 msgstrs = (msgstrs,) |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
61 |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
62 for msgid, msgstr in izip(msgids, msgstrs): |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
63 if msgstr: |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
64 _validate_format(msgid, msgstr) |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
65 |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
66 |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
67 def _validate_format(format, alternative): |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
68 """Test format string `alternative` against `format`. `format` can be the |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
69 msgid of a message and `alternative` one of the `msgstr`\s. The two |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
70 arguments are not interchangeable as `alternative` may contain less |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
71 placeholders if `format` uses named placeholders. |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
72 |
416
3e2c8b5573a1
Removed `ValueError` raising for string formatting message checkers if the string does not contain any string formattings. The new behavior is undefined. This fixes at least one of the problems of the #150 ticket.
aronacher
parents:
414
diff
changeset
|
73 The behavior of this function is undefined if the string does not use |
3e2c8b5573a1
Removed `ValueError` raising for string formatting message checkers if the string does not contain any string formattings. The new behavior is undefined. This fixes at least one of the problems of the #150 ticket.
aronacher
parents:
414
diff
changeset
|
74 string formattings. |
352
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
75 |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
76 If the string formatting of `alternative` is compatible to `format` the |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
77 function returns `None`, otherwise a `TranslationError` is raised. |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
78 |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
79 Examples for compatible format strings: |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
80 |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
81 >>> _validate_format('Hello %s!', 'Hallo %s!') |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
82 >>> _validate_format('Hello %i!', 'Hallo %d!') |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
83 |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
84 Example for an incompatible format strings: |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
85 |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
86 >>> _validate_format('Hello %(name)s!', 'Hallo %s!') |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
87 Traceback (most recent call last): |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
88 ... |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
89 TranslationError: the format strings are of different kinds |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
90 |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
91 This function is used by the `python_format` checker. |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
92 |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
93 :param format: The original format string |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
94 :param alternative: The alternative format string that should be checked |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
95 against format |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
96 :return: None on success |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
97 :raises TranslationError: on formatting errors |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
98 """ |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
99 |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
100 def _parse(string): |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
101 result = [] |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
102 for match in PYTHON_FORMAT.finditer(string): |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
103 name, format, typechar = match.groups() |
361 | 104 if typechar == '%' and name is None: |
352
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
105 continue |
360
6cc92793c047
Convert format strings to str for nicer error messages (no u prefix) in the python_format checker.
aronacher
parents:
355
diff
changeset
|
106 result.append((name, str(typechar))) |
352
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
107 return result |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
108 |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
109 def _compatible(a, b): |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
110 if a == b: |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
111 return True |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
112 for set in _string_format_compatibilities: |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
113 if a in set and b in set: |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
114 return True |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
115 return False |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
116 |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
117 def _check_positional(results): |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
118 positional = None |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
119 for name, char in results: |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
120 if positional is None: |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
121 positional = name is None |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
122 else: |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
123 if (name is None) != positional: |
353
0791b3bf42cc
Fixed a small bug in the python format string checker that caused the wrong exception to be thrown.
aronacher
parents:
352
diff
changeset
|
124 raise TranslationError('format string mixes positional ' |
0791b3bf42cc
Fixed a small bug in the python format string checker that caused the wrong exception to be thrown.
aronacher
parents:
352
diff
changeset
|
125 'and named placeholders') |
352
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
126 return bool(positional) |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
127 |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
128 a, b = map(_parse, (format, alternative)) |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
129 |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
130 # now check if both strings are positional or named |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
131 a_positional, b_positional = map(_check_positional, (a, b)) |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
132 if a_positional and not b_positional and not b: |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
133 raise TranslationError('placeholders are incompatible') |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
134 elif a_positional != b_positional: |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
135 raise TranslationError('the format strings are of different kinds') |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
136 |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
137 # if we are operating on positional strings both must have the |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
138 # same number of format chars and those must be compatible |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
139 if a_positional: |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
140 if len(a) != len(b): |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
141 raise TranslationError('positional format placeholders are ' |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
142 'unbalanced') |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
143 for idx, ((_, first), (_, second)) in enumerate(izip(a, b)): |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
144 if not _compatible(first, second): |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
145 raise TranslationError('incompatible format for placeholder ' |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
146 '%d: %r and %r are not compatible' % |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
147 (idx + 1, first, second)) |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
148 |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
149 # otherwise the second string must not have names the first one |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
150 # doesn't have and the types of those included must be compatible |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
151 else: |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
152 type_map = dict(a) |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
153 for name, typechar in b: |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
154 if name not in type_map: |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
155 raise TranslationError('unknown named placeholder %r' % name) |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
156 elif not _compatible(typechar, type_map[name]): |
364
8c9dc94062c0
Fixed a typo in the message checkers (tests will follow)
aronacher
parents:
361
diff
changeset
|
157 raise TranslationError('incompatible format for ' |
8c9dc94062c0
Fixed a typo in the message checkers (tests will follow)
aronacher
parents:
361
diff
changeset
|
158 'placeholder %r: ' |
8c9dc94062c0
Fixed a typo in the message checkers (tests will follow)
aronacher
parents:
361
diff
changeset
|
159 '%r and %r are not compatible' % |
8c9dc94062c0
Fixed a typo in the message checkers (tests will follow)
aronacher
parents:
361
diff
changeset
|
160 (name, typechar, type_map[name])) |
352
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
161 |
8860097a9765
The builtin checkers don't require setuptools any longer, validate_format and python_format from the checkers module are merged into one now.
aronacher
parents:
234
diff
changeset
|
162 |
355
9a2618ab9bbc
Refactored the checker system. It's now possible to partially validate translations on a per-message level.
aronacher
parents:
353
diff
changeset
|
163 def _find_checkers(): |
9a2618ab9bbc
Refactored the checker system. It's now possible to partially validate translations on a per-message level.
aronacher
parents:
353
diff
changeset
|
164 try: |
9a2618ab9bbc
Refactored the checker system. It's now possible to partially validate translations on a per-message level.
aronacher
parents:
353
diff
changeset
|
165 from pkg_resources import working_set |
9a2618ab9bbc
Refactored the checker system. It's now possible to partially validate translations on a per-message level.
aronacher
parents:
353
diff
changeset
|
166 except ImportError: |
9a2618ab9bbc
Refactored the checker system. It's now possible to partially validate translations on a per-message level.
aronacher
parents:
353
diff
changeset
|
167 return [num_plurals, python_format] |
9a2618ab9bbc
Refactored the checker system. It's now possible to partially validate translations on a per-message level.
aronacher
parents:
353
diff
changeset
|
168 checkers = [] |
9a2618ab9bbc
Refactored the checker system. It's now possible to partially validate translations on a per-message level.
aronacher
parents:
353
diff
changeset
|
169 for entry_point in working_set.iter_entry_points('babel.checkers'): |
9a2618ab9bbc
Refactored the checker system. It's now possible to partially validate translations on a per-message level.
aronacher
parents:
353
diff
changeset
|
170 checkers.append(entry_point.load()) |
9a2618ab9bbc
Refactored the checker system. It's now possible to partially validate translations on a per-message level.
aronacher
parents:
353
diff
changeset
|
171 return checkers |
9a2618ab9bbc
Refactored the checker system. It's now possible to partially validate translations on a per-message level.
aronacher
parents:
353
diff
changeset
|
172 |
9a2618ab9bbc
Refactored the checker system. It's now possible to partially validate translations on a per-message level.
aronacher
parents:
353
diff
changeset
|
173 |
9a2618ab9bbc
Refactored the checker system. It's now possible to partially validate translations on a per-message level.
aronacher
parents:
353
diff
changeset
|
174 checkers = _find_checkers() |