# HG changeset patch # User mgood # Date 1237766872 0 # Node ID 6a2dc6cdc4dd6389027bb69b799311b45ea2137f # Parent 79dd34e914a7a6a925db010c44367e95e749db9d Make `BittenNotify` use the config properties instead of directly loking in `self.config` diff --git a/bitten/notify.py b/bitten/notify.py --- a/bitten/notify.py +++ b/bitten/notify.py @@ -42,14 +42,10 @@ self.email.notify(build_info) def _should_notify(self, build): - notify_on_failure = self.config.getbool(CONFIG_SECTION, - NOTIFY_ON_FAILURE) - notify_on_success = self.config.getbool(CONFIG_SECTION, - NOTIFY_ON_SUCCESS) build_is_failure = (build.status == Build.FAILURE) build_is_success = (build.status == Build.SUCCESS) - return (build_is_failure and notify_on_failure) or \ - (build_is_success and notify_on_success) + return (build_is_failure and self.notify_on_failure) or \ + (build_is_success and self.notify_on_success) # IBuildListener methods