# HG changeset patch # User cmlenz # Date 1215511135 0 # Node ID 56f0ad35c60a8aa8d33eac3cd4c2cd7eecce1164 # Parent 9bff10727d58cad659369cf2c33212809e3cb115 Log errors when build master encounters an XML parse error. diff --git a/bitten/master.py b/bitten/master.py --- a/bitten/master.py +++ b/bitten/master.py @@ -103,6 +103,8 @@ try: elem = xmlio.parse(req.read()) except xmlio.ParseError, e: + self.log.error('Error parsing build initialization request: %s', e, + exc_info=True) raise HTTPBadRequest('XML parser error') slavename = elem.attr['name'] @@ -190,6 +192,8 @@ try: elem = xmlio.parse(req.read()) except xmlio.ParseError, e: + self.log.error('Error parsing build step result: %s', e, + exc_info=True) raise HTTPBadRequest('XML parser error') stepname = elem.attr['step'] @@ -222,6 +226,8 @@ step.started = int(_parse_iso_datetime(elem.attr['time'])) step.stopped = step.started + float(elem.attr['duration']) except ValueError, e: + self.log.error('Error parsing build step timestamp: %s', e, + exc_info=True) raise HTTPBadRequest(e.args[0]) if elem.attr['status'] == 'failure': self.log.warning('Build %s step %s failed', build.id, stepname)