# HG changeset patch # User cmlenz # Date 1130364357 0 # Node ID 1d01273abcb0eb6eafb474541a2ba8906faf458b # Parent 5f84af72d17f315ed4377dd74bc965e227692570 * Applied patch by Sven Reimers to fix the `` task on Windows. Closes #69. * The tests for `bitten.slave` left temporary files around. No longer. diff --git a/bitten/build/javatools.py b/bitten/build/javatools.py --- a/bitten/build/javatools.py +++ b/bitten/build/javatools.py @@ -27,6 +27,7 @@ executable = os.path.join(ant_home, 'bin', 'ant') logfile = tempfile.NamedTemporaryFile(prefix='ant_log', suffix='.xml') + logfile.close() if args: args = shlex.split(args) else: @@ -51,7 +52,7 @@ error_logged = False log_elem = xmlio.Fragment() try: - xml_log = xmlio.parse(logfile) + xml_log = xmlio.parse(file(logfile.name, 'r')) def collect_log_messages(node): for child in node.children(): if child.name == 'message': diff --git a/bitten/tests/slave.py b/bitten/tests/slave.py --- a/bitten/tests/slave.py +++ b/bitten/tests/slave.py @@ -22,7 +22,7 @@ def setUp(self): self.work_dir = tempfile.mkdtemp(prefix='bitten_test') - self.slave = Slave(None, None) + self.slave = Slave(None, None, work_dir=self.work_dir) self.handler = OrchestrationProfileHandler(Mock(session=self.slave)) def tearDown(self):